From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
Cc: | pgsql-patches(at)postgresql(dot)org, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: [HACKERS] Fix mdsync never-ending loop problem |
Date: | 2007-04-10 21:49:05 |
Message-ID: | 3928.1176241745@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
I wrote:
> Actually, on second look I think the key idea here is Takahiro-san's
> introduction of a cancellation flag in the hashtable entries, to
> replace the cases where AbsorbFsyncRequests can try to delete entries.
> What that means is mdsync() doesn't need an outer retry loop at all:
I fooled around with this idea and came up with the attached patch.
It seems to do what's intended but could do with more eyeballs and
testing before committing. Comments please?
(Note: I ignored my own advice not to reindent. Sorry ...)
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 14.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kris Kennaway | 2007-04-10 22:09:24 | Re: Anyone interested in improving postgresql scaling? |
Previous Message | Robert Haas | 2007-04-10 21:41:53 | Re: Eliminating unnecessary left joins |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-04-10 22:17:14 | Re: Table function support |
Previous Message | Alvaro Herrera | 2007-04-10 21:36:15 | Re: Autovacuum multiworkers, try 6 |