Skip site navigation (1) Skip section navigation (2)

Re: Cygwin PostgreSQL CVS Patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-ports(at)postgresql(dot)org
Subject: Re: Cygwin PostgreSQL CVS Patch
Date: 2001-01-18 18:03:18
Message-ID: 3924.979840998@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-ports
Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> 1. Add the following cruft right before the above:

> #ifdef __CYGWIN__
> #include <cygwin/version.h>
> #endif

> 2. Move the including of os.h to somewhere before the above.

I don't like #2 since there may be (now or in the future) port header
files that depend on being able to override config.h choices.

A third alternative is to remove all mention of cygwin from the
test in config.h, allowing it to #define HAVE_UNIX_SOCKETS always,
and then in the cygwin os.h #undef it again if it's old cygwin.

			regards, tom lane

In response to

Responses

pgsql-ports by date

Next:From: Jason TishlerDate: 2001-01-18 18:12:21
Subject: Re: Cygwin PostgreSQL CVS Patch
Previous:From: Jason TishlerDate: 2001-01-18 17:59:45
Subject: Re: Cygwin PostgreSQL CVS Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group