Andrew Dunstan said:
> Bruce Momjian said:
>> Log Message:
>> Add regression tests for CSV and \., and add automatic quoting of a
single column dump that has a \. value, so the load works properly. I also
added documentation describing this issue.
> This seems unnecessarily elaborate, in code that is already byzantine. I
think we can safely quote *any* field that has \. regardless of whether or
not it is a singleton. There's no need to make a single column a special
case - if it's valid for a singleton it's valid for any, and vice versa.
Now that I've woken up properly I realise that it's also just wrong - it
will miss the case we need to catch of the first column of a multi-column
line beginning with \. - just treat them all the same and all will be well.
Also, this test is suspicious:
strcmp(string, "\\.") == 0
Don't we also want to quote it if the field reads \.x ?
strncmp(string, "\\.",2) == 0
seems like it would be a better test.
pgsql-committers by date
|Next:||From: Bruce Momjian||Date: 2005-12-28 14:38:32|
|Subject: pgsql: Update COPY CSV \.|
|Previous:||From: Andrew Dunstan||Date: 2005-12-28 12:35:59|
|Subject: Re: pgsql: Add regression tests for CSV and \., and add automatic quoting of|