Re: Plperl Safe version check fails for Safe 2.09

Mark Kirkwood <markir(at)coretech(dot)co(dot)nz> writes:
> It seems that the check in src/pl/plperl/plperl.c
> eval_pv((safe_version < 2.09 ? safe_bad : safe_ok), FALSE);
> is not working quite as expected (CVS HEAD from today):

Yah know, I looked at that on Monday and said to myself "Self, that
looks like a rounding problem waiting to happen" ... but in the absence
of a trouble report didn't want to mess with it.

Part of the problem is that Perl NV is double, not float, and so the
declaration of safe_version is wrong on its face. But even with it
properly declared, exact comparison of double values is playing with
fire. I'd be inclined to change it to something like

double safe_version;
...
if (safe_version < 2.0899999) ...

regards, tom lane