Skip site navigation (1) Skip section navigation (2)

Re: error in compilation!

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: error in compilation!
Date: 2006-05-27 19:18:04
Message-ID: 3878.1148757484@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I am thinking it is best to always use E'' in that case.  OK?

I'm planning to revert it to the previous logic: E if there's any
backslash.  I think we have to do likewise in quote_literal() for
much the same reason: insufficient confidence that we know how
the result will be used.  (Note dblink uses quote_literal for
strings it will send to the other database.)

Currently looking through the rest of the patch.  I'm wondering
about appendStringLiteral: maybe we should kill that entirely
in favor of using PQescapeStringConn?  It's not nearly bright
enough about encoding for instance (and it *will* be used in
client-only encodings).

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Gurjeet SinghDate: 2006-05-27 19:35:08
Subject: Re: error in compilation!
Previous:From: Michael FuhrDate: 2006-05-27 19:06:58
Subject: anoncvs still slow

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group