Skip site navigation (1) Skip section navigation (2)

Re: [PORTS] Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

From: Uncle George <gatgul(at)voicenet(dot)com>
To: PostgreSQL bugs mailing list <pgsql-bugs(at)postgreSQL(dot)org>
Cc: PostgreSQL ports mailing list <pgsql-ports(at)postgreSQL(dot)org>
Subject: Re: [PORTS] Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc
Date: 1999-10-10 11:38:13
Message-ID: 38007AA5.FCDCA567@voicenet.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-ports
egcs, also defines both __alpha & __alpha__
( if u havent't test there already ) I believe this covers all avail compiled
on the Digital Alpha  box
gat
Tom Lane wrote:

> "Pedro J. Lobo" <pjlobo(at)euitt(dot)upm(dot)es> writes:
> > Someone has changed the "#if defined(__alpha)" tests that existed in
> > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
> > is that DEC (┬┐Compaq?) C only defines __alpha, (gcc defines both __alpha
> > and __alpha__) so it doesn't work anymore.
>
> I thought that was bogus when it was done.  Should be
>         #if defined(__alpha) || defined(__alpha__)
> to cover both compilers.
>
> > In fact, there are two places where the test is used, one inside a "#if
> > defined(__GNUC__)" and the other one inside the corresponding "#else". It
> > seems that the easiest sollution is to change the check inside the "#else"
> > back to "#if defined(__alpha)".
>
> ... which would break whichever compiler is being used by the person who
> submitted the patch.  I don't think it was changed on a whim.
>
>                         regards, tom lane
>
> ************


In response to

pgsql-ports by date

Next:From: Brian EdmondsDate: 1999-10-10 15:26:05
Subject: Linux 2.2.12 SMP build success report
Previous:From: Peter SchaeferDate: 1999-10-09 16:18:14
Subject: 'current'::datetime

pgsql-bugs by date

Next:From: Tom LaneDate: 1999-10-10 16:13:07
Subject: Re: [BUGS] Three Regression Test Problems involving dates
Previous:From: Duncan KinderDate: 1999-10-09 23:24:35
Subject: Three Regression Test Problems involving dates

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group