Skip site navigation (1) Skip section navigation (2)

Re: BUG #4862: different results in to_date() between 8.3.7 & 8.4.RC1

From: Brendan Jurd <direvus(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeremy Ford <jeremford(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: BUG #4862: different results in to_date() between 8.3.7 & 8.4.RC1
Date: 2009-06-22 17:16:08
Message-ID: 37ed240d0906221016y64eab668r8347cce1a3eaa012@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
2009/6/23 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Brendan Jurd <direvus(at)gmail(dot)com> writes:
>> I should be able to get the same results by snipping an extra
>> strspace_len() characters in the new code path in
>> from_char_parse_int_len().  This ought to be a one-line fix that
>> doesn't clobber the good parts of my work so far.  I'll run some tests
>> and then post a patch within the hour.  Does that work for you?
>
> +1
>

[cross-posting to -hackers]

Here's a one-line patch to fix a regression in the new from_char code
I introduced into 8.4.

Versions <= 8.3 skipped over any whitespace immediately preceding any
integer field, and this behaviour was lost in HEAD when my from_char
patch was committed back in September '08 [1].

Fortunately, since the code has been refactored, this now only needs
to be repaired in one place =)

With thanks to Jeremy Ford for sending in his bug report, and an
abject mea culpa.

Cheers,
BJ

[1] http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6f09ab2c24491a217f8b88012aababf3b723b902

Attachment: from_char-skip-whitespace.diff
Description: application/octet-stream (527 bytes)

In response to

Responses

pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2009-06-22 17:37:04
Subject: Re: 8.4 open item: copy performance regression?
Previous:From: David FetterDate: 2009-06-22 17:08:15
Subject: Re: security checks for largeobjects?

pgsql-bugs by date

Next:From: Magnus HaganderDate: 2009-06-22 17:34:04
Subject: Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq
Previous:From: Lars KanisDate: 2009-06-22 16:50:17
Subject: Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group