From: | Brendan Jurd <direvus(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Jeremy Ford <jeremford(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: BUG #4862: different results in to_date() between 8.3.7 & 8.4.RC1 |
Date: | 2009-06-22 17:16:08 |
Message-ID: | 37ed240d0906221016y64eab668r8347cce1a3eaa012@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
2009/6/23 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Brendan Jurd <direvus(at)gmail(dot)com> writes:
>> I should be able to get the same results by snipping an extra
>> strspace_len() characters in the new code path in
>> from_char_parse_int_len(). This ought to be a one-line fix that
>> doesn't clobber the good parts of my work so far. I'll run some tests
>> and then post a patch within the hour. Does that work for you?
>
> +1
>
[cross-posting to -hackers]
Here's a one-line patch to fix a regression in the new from_char code
I introduced into 8.4.
Versions <= 8.3 skipped over any whitespace immediately preceding any
integer field, and this behaviour was lost in HEAD when my from_char
patch was committed back in September '08 [1].
Fortunately, since the code has been refactored, this now only needs
to be repaired in one place =)
With thanks to Jeremy Ford for sending in his bug report, and an
abject mea culpa.
Cheers,
BJ
Attachment | Content-Type | Size |
---|---|---|
from_char-skip-whitespace.diff | application/octet-stream | 528 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2009-06-22 17:34:04 | Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq |
Previous Message | Lars Kanis | 2009-06-22 16:50:17 | Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq |
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2009-06-22 17:37:04 | Re: 8.4 open item: copy performance regression? |
Previous Message | David Fetter | 2009-06-22 17:08:15 | Re: security checks for largeobjects? |