Skip site navigation (1) Skip section navigation (2)

Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp)

From: Brendan Jurd <direvus(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alex Hunsaker <badalex(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp)
Date: 2009-01-27 06:09:19
Message-ID: 37ed240d0901262209h18de77dbnbcaf0079a6203e8a@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Jan 27, 2009 at 3:25 PM, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> On Tue, Jan 27, 2009 at 3:05 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> strncpy is generally deprecated; any remaining uses you find of it
>> are probably only there for lack of round tuits.  Use strlcpy in new
>> code, unless there's a pretty strong argument that strncpy is actually
>> clearer for a given usage.
>>
>
> Thanks for clearing that up Tom.  I will update the patch to use
> strlcpy shortly.
>

Okay, I've attached a new version of the patch with strlcpy used in
from_char_set_int_len() and from_char_seq_search().  I've also
included an incremental patch which shows the differences between
version 0 and version 1.

Cheers,
BJ

Attachment: ampm-seqsearch_0_to_1.diff
Description: application/octet-stream (1.5 KB)
Attachment: ampm-seqsearch_1.diff.bz2
Description: application/x-bzip2 (5.5 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2009-01-27 06:15:04
Subject: Re: 8.4 release planning
Previous:From: Pavel StehuleDate: 2009-01-27 06:05:54
Subject: Re: 8.4 release planning

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group