From:
"Brendan Jurd" <direvus(at)gmail(dot)com>
To:
"Ron Mayer" <rm_pg(at)cheapcomplexdevices(dot)com>
Cc:
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers(at)postgresql(dot)org
Subject:
Re: Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle
Date:
2008-11-05 05:02:11
Message-ID:
37ed240d0811042102q78df5b86t2ff2092a75d371d7@mail.gmail.com (view raw or flat )
Thread:
2008-09-10 00:15:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-10 23:50:25 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2008-09-11 00:10:17 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2008-09-11 00:21:27 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-11 23:22:54 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-11 23:39:27 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-11 23:48:34 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-12 00:05:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-12 00:08:29 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-12 00:32:06 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-12 00:42:13 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-12 19:09:35 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-12 20:32:13 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-12 20:40:02 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-12 20:55:10 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-12 21:04:38 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-12 23:50:10 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-13 04:15:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-13 20:35:54 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-15 21:36:18 from R Mayer <pg_cert(at)cheapcomplexdevices(dot)com>
2008-09-15 21:48:41 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-15 21:58:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-15 22:03:08 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2008-09-15 22:13:03 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2008-10-09 18:50:17 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-10-09 19:14:37 from Kenneth Marshall <ktm(at)rice(dot)edu>
2008-10-09 19:42:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-10-09 21:23:03 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-10-09 21:54:52 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-10-10 05:16:43 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-10-09 19:47:24 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2008-10-09 20:02:58 from Kenneth Marshall <ktm(at)rice(dot)edu>
2008-09-15 22:15:04 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-15 22:19:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-15 22:27:34 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-17 19:03:13 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-20 17:09:28 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-10-02 10:01:00 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-10-02 10:31:40 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-05 15:50:41 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-05 16:36:51 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-06 07:06:24 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-06 16:26:31 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-06 16:35:39 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-07 04:58:48 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-07 15:19:39 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-10 02:36:30 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-10 14:26:04 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-10 15:36:37 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-10 17:37:40 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-10 18:51:44 from R Mayer <pg_cert(at)cheapcomplexdevices(dot)com>
2008-11-10 19:15:40 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-10 19:43:03 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-11 00:58:17 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-11 14:11:12 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-11 02:46:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-01 00:22:55 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-01 00:30:58 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-01 04:42:23 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-10 20:14:51 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-10 21:41:09 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-11 18:32:35 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-11 18:54:50 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-11 19:13:09 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-11 19:19:43 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-12 01:40:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-12 01:53:41 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-12 01:59:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-12 22:28:56 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-13 15:25:01 from Michael Meskes <meskes(at)postgresql(dot)org>
2008-11-21 01:07:40 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-26 14:28:49 from Michael Meskes <meskes(at)postgresql(dot)org>
2008-11-26 14:31:48 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-26 16:31:51 from Michael Meskes <meskes(at)postgresql(dot)org>
2008-11-26 16:54:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-11 19:36:12 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-04 05:22:44 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-04 14:08:23 from "Robert Haas" <robertmhaas(at)gmail(dot)com>
2008-11-04 15:40:56 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-04 15:50:09 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-04 15:57:40 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2008-11-04 16:00:09 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-04 17:55:29 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-04 20:34:35 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-05 05:02:11 from "Brendan Jurd" <direvus(at)gmail(dot)com>
2008-11-05 06:34:47 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 01:57:53 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 02:45:36 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 02:56:48 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 03:08:24 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 03:29:35 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 19:25:53 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 19:39:31 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 19:42:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 19:44:27 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 19:47:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 19:56:23 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 20:07:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 20:30:30 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 20:50:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 21:03:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 19:39:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 20:06:20 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 20:30:53 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-09 00:24:37 from Chuck McDevitt <cmcdevitt(at)greenplum(dot)com>
2008-11-09 01:00:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 15:11:06 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-08 03:03:24 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-08 03:11:25 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-09 00:31:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-09 15:36:03 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-11-05 14:39:30 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-23 01:51:16 from Bruce Momjian <bruce(at)momjian(dot)us>
2008-09-23 03:54:58 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-23 12:23:43 from Bruce Momjian <bruce(at)momjian(dot)us>
2008-09-11 01:44:11 from Josh Berkus <josh(at)agliodbs(dot)com>
2008-09-15 23:37:32 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-15 23:42:29 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-15 23:50:57 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-16 20:29:01 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-16 21:52:45 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-16 22:20:02 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-16 22:36:27 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-16 22:50:51 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-17 12:29:11 from "Stephen R(dot) van den Berg" <srb(at)cuci(dot)nl>
2008-09-17 12:38:49 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-09-17 14:19:18 from Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
2008-09-17 15:19:35 from "Stephen R(dot) van den Berg" <srb(at)cuci(dot)nl>
Lists:
pgsql-hackers
On Wed, Nov 5, 2008 at 7:34 AM, Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com> wrote:
> Brendan Jurd wrote:
>> When I ran the regression tests, I got one failure in the new interval
>
> Fixed, and I did a bit more testing both with and without
> HAVE_INT64_TIMESTAMP.
Confirmed, all regression tests now pass on my system with the updated patch.
>> The C code has some small stylistic inconsistencies; ...
>> ... spaces around binary operators are missing (e.g., "(fsec<0)").
>
> Thanks. Fixed these.
>
>> ...function calls missing the space after the argument separator...
>
> I think I fixed all these now too.
Awesome. As far as I can tell, you got them all. I don't have any
further nits to pick about the code style.
The changes to the documentation all look good. I did notice one
final typo that I think was introduced in the latest version.
doc/src/sgml/datatype.sgml:2270 has "Nonstandardrd" instead of
"Nonstandard".
But, apart from that I have no further feedback.
I will sign off on this one and mark it "Ready for committer" in the commitfest.
Review of the other two patches coming soon to a mail client near you.
Cheers,
BJ
In response to
Responses
pgsql-hackers by date
Next :From: Bruce MomjianDate: 2008-11-05 05:02:29Subject : Re: Re: [BUGS] libpq does not manage SSL callbacks
properly when other libraries are involved.Previous :From : Robert HaasDate : 2008-11-05 04:51:32Subject : Re: [WIP] In-place upgrade
