Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Text <-> C string

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] Text <-> C string
Date: 2008-03-28 19:40:46
Message-ID: 37ed240d0803281240g73e4433i4cb356410045f5c7@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On 29/03/2008, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I intentionally didn't touch xml.c, nor anyplace that is not dealing
>  in text, even if it happens to be binary-compatible with text.
>

Hmm, okay.  My original submission did include a few such changes; for
example, in xml_in and xml_out_internal I saw that the conversion
between xmltype and cstring was identical to the text conversion, so I
went ahead and used the text functions.  Feedback upthread suggested
that it was okay to go ahead with casting in identical cases. [1]

I saw that these changes made it into the commit, so I assumed that it
was the right call.

If we don't want to meddle with xmltype/bytea/VarChar at all, we'll
have to revert those changes, and I'll have to seriously scale back
the cleanup patch I was about to post.

Regards,
BJ

[1] http://archives.postgresql.org/pgsql-hackers/2007-09/msg01094.php

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-03-28 19:47:07
Subject: Re: Is psql command line interface broken on HEAD?
Previous:From: Tom LaneDate: 2008-03-28 19:26:21
Subject: Re: [PATCHES] Text <-> C string

pgsql-patches by date

Next:From: Bruce MomjianDate: 2008-03-28 20:26:42
Subject: Re: [PATCHES] Implemented current_query
Previous:From: Tom LaneDate: 2008-03-28 19:26:21
Subject: Re: [PATCHES] Text <-> C string

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group