Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Function structure in formatting.c

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Function structure in formatting.c
Date: 2008-03-24 10:49:04
Message-ID: 37ed240d0803240349i690c6b9bn5bd530d2b5885bbb@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On 23/03/2008, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Working through this patch now.  I found one thing that seems to be
>  a mistake (probably an overenthusiastic search&replace): the patch
>  changes
>  -       {"iy", 2, dch_date, DCH_IY, TRUE},
>  to
>  +       {"iyear", 2, DCH_IY, TRUE},
>
>  The removal of dch_date is intended, but surely the keyword should
>  still be "iy".  I'm proceeding on that assumption, but if this change
>  was actually intended, please explain.
>

Nice catch.  Not sure how that got in there, but your theory about a
search & replace gone awry seems the most likely.

Now that the functions have been refactored, I'm looking forward to
getting back into improving the sanity checking in to_date.

Cheers,
BJ

In response to

pgsql-hackers by date

Next:From: Gurjeet SinghDate: 2008-03-24 14:01:32
Subject: Re: Problem with site doc search
Previous:From: Brendan JurdDate: 2008-03-24 10:37:36
Subject: Re: [HACKERS] quote_literal with NULL

pgsql-patches by date

Next:From: Brendan JurdDate: 2008-03-24 16:30:48
Subject: Re: [PATCHES] Show INHERIT in \du
Previous:From: Brendan JurdDate: 2008-03-24 10:37:36
Subject: Re: [HACKERS] quote_literal with NULL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group