Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Should libedit be preferred to libreadline?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Chris Browne <cbbrowne(at)acm(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Date: 2005-12-02 17:28:38
Message-ID: 3787.1133544518@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patchespgsql-ports
Chris Browne <cbbrowne(at)acm(dot)org> writes:
> To my mind, giving BIG weight to the opinions of the relatively small
> set of individuals that manage PostgreSQL packages for the popular
> distributions of Linux and *BSD seems fairly appropriate.

The packagers are bright enough to adapt to whatever we do --- it's
the people who build their own from source that I'm worried about.
--with-readline has worked fine for libedit users for a long time,
and suddenly changing its semantics strikes me as a bad idea.

The other problem with the "let's be deterministic" argument is that
it rests on a fallacy, which is that configure can reliably tell the
difference between libreadline and libedit.  Darwin, for example, goes
to some lengths to confuse matters.

(I think I'd actually be for the determinism point of view if it could
provide an #ifdef flag saying which library is in use --- then we could
fix the write_history return value problem we're seeing on Darwin ---
but I don't think we can do it short of a behavioral probe during
configure.)

			regards, tom lane

In response to

Responses

pgsql-ports by date

Next:From: Bruce MomjianDate: 2005-12-02 18:23:35
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Chris BrowneDate: 2005-12-02 17:14:09
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-12-02 17:39:11
Subject: Reduce NUMERIC size by 2 bytes, reduce max length to 508 digits
Previous:From: Jaime CasanovaDate: 2005-12-02 17:25:58
Subject: Re: 8.1, OID's and plpgsql

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-12-02 17:39:11
Subject: Reduce NUMERIC size by 2 bytes, reduce max length to 508 digits
Previous:From: Bruce MomjianDate: 2005-12-02 17:26:53
Subject: Re: Case Conversion Fix for MB Chars

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group