From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Boszormenyi Zoltan <zb(at)cybertec(dot)at>
Cc:
Magnus Hagander <magnus(at)hagander(dot)net>,
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>,
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [PATCH] Make pg_basebackup configure and start standby [Review]
Date:
2013-01-02 00:24:51
Message-ID:
3748.1357086291@sss.pgh.pa.us (view raw or flat )
Thread:
2012-09-20 10:30:47 from Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
2012-10-03 16:15:58 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-04 03:24:31 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-10-04 04:47:09 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-04 10:42:37 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-04 11:17:49 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-04 14:43:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-10-04 16:19:36 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-10 06:58:36 from Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
2012-10-10 13:12:15 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-10 16:23:40 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-10-10 18:36:07 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-10 19:58:08 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-11 00:04:54 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-10-11 00:02:46 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-10-12 20:21:56 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-10-14 11:41:07 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-14 16:02:20 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2012-10-14 16:41:13 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-14 20:23:48 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-14 20:26:07 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-14 20:31:10 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-15 07:46:19 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-23 14:52:55 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-10-23 15:08:56 from Magnus Hagander <magnus(at)hagander(dot)net>
2012-11-18 16:20:20 from Magnus Hagander <magnus(at)hagander(dot)net>
2012-11-18 19:24:25 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-20 16:03:59 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-20 16:14:57 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-20 19:32:56 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-21 10:35:00 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-21 13:19:44 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-11-21 14:12:21 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-21 14:28:31 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-11-21 14:29:02 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-11-21 14:30:54 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-21 17:39:58 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-22 10:06:52 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-22 16:57:01 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-11-30 09:13:27 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-01 16:18:34 from Magnus Hagander <magnus(at)hagander(dot)net>
2013-01-01 18:26:14 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-02 00:24:51 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2013-01-02 08:59:19 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-02 09:12:44 from Magnus Hagander <magnus(at)hagander(dot)net>
2013-01-02 09:37:21 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-02 10:54:07 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-03 12:33:46 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-05 14:41:57 from Magnus Hagander <magnus(at)hagander(dot)net>
2013-01-05 15:58:01 from Magnus Hagander <magnus(at)hagander(dot)net>
2013-01-05 16:17:03 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-02 12:59:50 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-02-12 15:14:25 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-01-01 17:25:03 from Magnus Hagander <magnus(at)hagander(dot)net>
2013-01-01 18:13:55 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2013-01-01 18:20:34 from Magnus Hagander <magnus(at)hagander(dot)net>
2012-10-14 15:57:10 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2012-10-14 16:10:55 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Lists:
pgsql-hackers
Boszormenyi Zoltan <zb(at)cybertec(dot)at> writes:
> 2013-01-01 17:18 keltezssel, Magnus Hagander rta:
>> That way we can get around the whole need for changing memory allocation across all the
>> frontends, no? Like the attached.
> Sure it's simpler but then the consistent look of the code is lost.
> What about the other patch to unify pg_malloc and friends?
> Basically all client code boils down to
> fprintf(stderr, ...)
> in different disguise in their error reporting, so that patch can
> also be simplified but it seems that the atexit() - either explicitly
> or hidden behind InitPostgresFrontend() - cannot be avoided.
Meh. I find it seriously wrongheaded that something as minor as an
escape_quotes() function should get to dictate both malloc wrappers
and error recovery handling throughout every program that might use it.
I like Magnus' version a lot better than that idea.
A bigger issue that I notice with this code is that it's only correct in
backend-safe encodings, as the comment mentions. If we're going to be
putting it into frontend programs, how safe is that going to be?
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Andrew DunstanDate: 2013-01-02 03:14:08Subject : Re: pgsql: Unify some tar functionality across different
partsPrevious :From : Tom LaneDate : 2013-01-02 00:15:44Subject : Re: default SSL compression (was: libpq compression)
