Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Ship documentation without intermediate tarballs Documentation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Ship documentation without intermediate tarballs Documentation
Date: 2009-08-10 15:59:51
Message-ID: 3747.1249919991@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On Monday 10 August 2009 09:26:33 Tom Lane wrote:
>> After this patch, "make clean" in the doc/src/sgml directory no longer
>> does anything useful.  Even "make distclean" fails to remove all the
>> cruft left behind by a build.  This needs to be rethought a bit,
>> else we are going to be shipping tarballs containing junk.

> make maintainer-clean is supposed to remove "everything".  make distclean is 
> supposed to remove things that are not supposed to be in the distribution.  If 
> you can identifiy something that should not be in the distribution and is not 
> removed by distclean, let me know.

After doing "make" then "make distclean" in doc/src/sgml, I see the
following undesirable files left behind:

-rw-rw-r-- 1 tgl tgl     58 Aug 10 11:51 version.sgml
-rw-rw-r-- 1 tgl tgl  38548 Aug 10 11:51 features-unsupported.sgml
-rw-rw-r-- 1 tgl tgl  42014 Aug 10 11:51 features-supported.sgml
-rw-rw-r-- 1 tgl tgl 345398 Aug 10 11:52 HTML.index
-rw-rw-r-- 1 tgl tgl 298859 Aug 10 11:52 bookindex.sgml
-rw-rw-r-- 1 tgl tgl      0 Aug 10 11:53 html-stamp

I would argue that both "make clean" and "make distclean" should remove
these.

Also, we seem to need .cvsignore entries for the html/ and manN/
subdirectories.  IMO the policy for .cvsignore is that anything
intentionally left behind by make distclean is to be cvsignore'd.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-08-10 16:09:55
Subject: Re: GRANT ON ALL IN schema
Previous:From: Robert HaasDate: 2009-08-10 15:59:28
Subject: Re: machine-readable explain output v4

pgsql-committers by date

Next:From: Tom LaneDate: 2009-08-10 16:10:19
Subject: pgsql: Adjust extract(epoch) example to clarify that it includes
Previous:From: Magnus HaganderDate: 2009-08-10 11:48:52
Subject: pgsql: Enable the use of multiple CPUs/cores when building on MSVC.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group