Skip site navigation (1) Skip section navigation (2)

Re: Syntax got translated

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Susanne Ebrecht <susanne(at)2ndquadrant(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Syntax got translated
Date: 2012-02-20 21:17:07
Message-ID: 371925a3a3fefe72f2455d207979cc7a@localhost (view raw or flat)
Thread:
Lists: pgsql-bugs
On Mon, 20 Feb 2012 15:55:54 -0500, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Guillaume Lelarge <guillaume(at)lelarge(dot)info> writes:
>> On Mon, 20 Feb 2012 14:15:34 -0300, Alvaro Herrera
>> <alvherre(at)commandprompt(dot)com> wrote:
>>> Excerpts from Susanne Ebrecht's message of sáb feb 18 18:11:54 -0300
>>>> I think that the constraint keyword "DEFAULT" should not be
translated
>>>> here.
> 
>> I don't see why the modifiers shouldn't be translatable. It's not as if
>> they were intended to be copied and pasted in a query. They are here to
>> help the user understand the different modifiers in each column.
> 
>> -1 to get rid of the translations.
> 
> It seems to boil down to whether you think the "Modifiers" column
> contains SQL, or a textual description of the column's properties.
> I could go either way on that, but I notice that the existing code
> is in the habit of truncating the default expression at 128 characters.
> If we want to decide that we're printing real, copy-and-pastable SQL,
> that seems like a bad idea.  On the other hand, if we're printing
> informational text, it's not an unreasonable thing.
> 

My first move was that truncating to 128 characters was bad idea. But in a
terminal, you have a limited number of columns, so it would make sense.

And, to me, it's a textual description. Not SQL. BTW, if it was SQL, when
I do \d tablename, I should get the complete SQL query to create the table,
not a description of the table definition. So, yeah, sure, the "Modifiers"
column doesn't contain SQL, it's a description.


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

In response to

pgsql-bugs by date

Next:From: Guillaume LelargeDate: 2012-02-20 21:19:55
Subject: Re: Syntax got translated
Previous:From: Susanne EbrechtDate: 2012-02-20 21:14:32
Subject: Re: Syntax got translated

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group