Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Including Snapshot Info with Indexes

From: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>
To: "Gokulakannan Somasundaram" <gokul007(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Including Snapshot Info with Indexes
Date: 2008-01-23 21:19:18
Message-ID: 36e682920801231319t31a7366crf24be34dedc4e532@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Doh!  Can you please send another patch with gram.y as well.  Mine is
missing all of the thick index stuff.

On Jan 23, 2008 2:45 PM, Gokulakannan Somasundaram <gokul007(at)gmail(dot)com> wrote:
> Thanks for reviewing the patch. Please go ahead and make the changes and
> re-submit the patch. I will take care, that i won't repeat the stated
> mistakes again.
>
> The Missing of Thick Keyword - i don't know how it got removed.
>
>
>
> Thanks,
> Gokul
>
>
>
> On Jan 23, 2008 10:49 PM, Jonah H. Harris <jonah(dot)harris(at)gmail(dot)com> wrote:
> > On Jan 23, 2008 11:28 AM, Gokulakannan Somasundaram <gokul007(at)gmail(dot)com>
> wrote:
> > > Fixed a type 'o'....
> >
> > I'm playing with this now against 8.3 HEAD.  Looks like there's a
> > couple things which are problematic:
> >
> > - DefineIndex was updated only in bootparse.c, not in bootparse.y
> > - The patch contains changes to pg_config.h
> > - THICK isn't defined in gram.y (as a token or under
> > unreserved_keywords), so compilation of keywords.c fails.
> >
> > In the future, please make changes to the proper pre-built files so
> > that someone doesn't have to configure it, then patch it.  I have them
> > fixed and will submit the patch back here if you'd like.  Or, you can
> > fix it.  It's up to you :)
> >
> >
> >
> >
> > --
> > Jonah H. Harris, Sr. Software Architect | phone: 732.331.1324
> > EnterpriseDB Corporation                | fax: 732.331.1301
> > 499 Thornall Street, 2nd Floor          | jonah(dot)harris(at)enterprisedb(dot)com
> > Edison, NJ 08837                        | http://www.enterprisedb.com/
> >
>
>



-- 
Jonah H. Harris, Sr. Software Architect | phone: 732.331.1324
EnterpriseDB Corporation                | fax: 732.331.1301
499 Thornall Street, 2nd Floor          | jonah(dot)harris(at)enterprisedb(dot)com
Edison, NJ 08837                        | http://www.enterprisedb.com/

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2008-01-23 21:32:59
Subject: Re: autonomous transactions
Previous:From: Alvaro HerreraDate: 2008-01-23 21:16:47
Subject: Re: autonomous transactions

pgsql-patches by date

Next:From: Hiroshi SaitoDate: 2008-01-24 01:27:56
Subject: Re: Compile of Test example is put into win32.mak of libpq.
Previous:From: Gokulakannan SomasundaramDate: 2008-01-23 19:45:02
Subject: Re: [HACKERS] Including Snapshot Info with Indexes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group