Skip site navigation (1) Skip section navigation (2)

Re: Display line numbers in SQL view

From: "Robins Tharakan" <tharakan(at)gmail(dot)com>
To: "Dave Page" <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Display line numbers in SQL view
Date: 2008-03-15 02:43:27
Message-ID: 36af4bed0803141943y5e9de8acyae1ef642acd6ddb1@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Dave,

True. In that case moving it as an option (with sane defaults) did seem like
a better way. So attached is a reworked patch that puts two options in
frmOptions.

1. A checkbox (in preferences tab) that applies to line numbers universally.
2. One checkbox (in the Query tab) specific to the SQL Query window.

The defaults ensure that the we maintain status quo (i.e. Line numbers are
enabled for Functions/Triggers but disabled for Query window).

Regards,
*Robins Tharakan*

---------- Forwarded message ----------
From: Dave Page <dpage(at)pgadmin(dot)org>
Date: Tue, Mar 4, 2008 at 3:11 PM
Subject: Re: [pgadmin-hackers] Display line numbers in SQL view
To: Robins Tharakan <tharakan(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org


On Mon, Mar 3, 2008 at 6:29 PM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
> Hi,
>
> During constant debugging of triggers / functions in office, I see the
need
> to copy paste a specific SQL string and run it in the SQL view to trace a
> bug on a given nth line. The problem being that the SQL view doesn't have
> line numbers in the margin like the Create function SQL tab.
>
> This patch adds line numbers to the SQL view as well.
>
> (This patch just enables the line-numbers in the margin, in case its
> desirable to have a checkbox that allows the user to enable/disable this,
we
> could have a menu option for that in the View menu. Should we ?)

This has been turned on and off repeatedly over the years. I think the
main problem is that some people have quite long scripts for which the
line numbers start to take up a lot of room. I wouldn't be opposed to
making it a configurable option though... but many of the options in
the query tool actually affect other instances of the styled text
control as well. I wonder if now is the time to think about moving
them to the main options dialogue?


--
Dave Page
EnterpriseDB UK Ltd: http://www.enterprisedb.com
PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk

Attachment: line_numbers_v6.patch
Description: text/x-patch (8.0 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Heikki LinnakangasDate: 2008-03-16 20:07:43
Subject: Re: Translating Keywords
Previous:From: Robins TharakanDate: 2008-03-15 02:25:16
Subject: Translating Keywords

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group