Skip site navigation (1) Skip section navigation (2)

pgSet MoveNext bug ?

From: "Robins Tharakan" <tharakan(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgSet MoveNext bug ?
Date: 2008-03-04 01:24:53
Message-ID: 36af4bed0803031724s681693e2pf392db9dfac4b5b4@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi,

While reading the code, the PGSet->MoveNext() definition seems to have a
small bug.

Since the PGSet->EOF() is defined as
bool Eof() const { return (!nRows || pos > nRows); }

I think it doesn't make sense to define PGSet->MoveNext() as
void MoveNext() { if (pos <= nRows) pos++; }

It should rather be
void MoveNext() { if (pos < nRows) pos++; }

The attached patch does the same.

Regards,
*Robins Tharakan*

Attachment: pgset_movenext_bug.patch
Description: text/x-patch (542 bytes)

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2008-03-04 09:41:52
Subject: Re: Display line numbers in SQL view
Previous:From: svnDate: 2008-03-03 21:35:39
Subject: SVN Commit by dpage: r7111 - trunk/pgadmin3/plugins

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group