Skip site navigation (1) Skip section navigation (2)

Re: Fwd: Filter by Selection on Grid

From: "Robins Tharakan" <robins(at)pobox(dot)com>
To: "Dave Page" <dpage(at)postgresql(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Fwd: Filter by Selection on Grid
Date: 2008-02-05 17:57:18
Message-ID: 36af4bed0802050957t27ab1b8dp56c9c6f0bfc1ea43@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Dave,

> OK, slow down :-). ... snip If you want to add more functionality, post a
new patch,
> otherwise the process just becomes a lot more complicated.

Sorry for jumping the gun !
I didn't think that this kind of a complication could arise....Guess it
shows that this is my first patch submission :-)

Sure, I'll try and keep separate patches in separate emails.
Attached is reworked patch which takes care of the issues that you
mentioned.

Updates in this patch:
1. Removed the extra separator that came up on right-click.
2. Enabled / Disabled the menu options while a query is running
3. The code also disables the right-click while a thread->IsRunning() is
true. (That should effectively disable the right-click when not needed right
?)

> One hint - test in a debug enabled build as you should then see
> asserts for things like enabling non-existant menu options.

I didn't see any error messages, but that could be probably because I
corrected the code before I ran it in debug mode.
Probably this'll help sometime in the future.

Anything else that needs more work ?

*Robins*

Attachment: filter_by_selection_v10.patch
Description: text/x-patch (13.9 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Robins TharakanDate: 2008-02-05 17:57:45
Subject: Re: Fwd: Filter by Selection on Grid
Previous:From: Dave PageDate: 2008-02-05 16:50:38
Subject: Re: A new feature patch and a bug fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group