Re: [HACKERS] Major breakage?

From: Vadim Mikheev <vadim(at)krs(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Major breakage?
Date: 1999-01-27 02:20:42
Message-ID: 36AE77FA.83BE9BA7@krs.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
>
> Nope, Vadim broke something. It looks like anything with a subplan
> will coredump in Monday's sources. executor/nodeSubPlan.c has
>
> bool
> ExecInitSubPlan(SubPlan *node, EState *estate, Plan *parent)
> {
> ...
> ExecCheckPerms(CMD_SELECT, 0, node->rtable, (Query *) NULL);
> ^^^^^^^^^^^^^^
>
> (and has had that for a long time, evidently). One of the additions
> Vadim checked in yesterday extends ExecCheckPerms() to try to use
> its parseTree argument --- unconditionally. Guaranteed null-pointer
> dereference.
>
> Perhaps ExecInitSubPlan is in error to pass a null parseTree; if not,
^^^^^^^^^^^^^^^^^^^^^^^^^^^
No.

> then ExecCheckPerms needs to be modified to cope. I don't understand
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Yes.

> either routine enough to fix it correctly.

Thanks!

Unfortunately, I can't fix this in CVS - I'm changing
execMain.c now to support READ COMMITTED mode. Could someone
add check in ExecCheckPerms ?
Sorry.

Vadim

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 1999-01-27 07:23:50 MB big5 support patch (current)
Previous Message The Hermit Hacker 1999-01-27 01:18:12 Re: [PATCHES] mb support fix