Re: [HACKERS] Upgrades for 6.4.1

From: "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
To: Jan Wieck <jwieck(at)debis(dot)com>
Cc: hannu(at)trust(dot)ee, maillist(at)candle(dot)pha(dot)pa(dot)us, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Upgrades for 6.4.1
Date: 1998-12-19 02:58:32
Message-ID: 367B1658.6B3BD9@alumni.caltech.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Easy - and the type coersion stuff helps alot!
> Up to now (1.5 hours hacking) I have a NUMERIC type that
> handles '+' completely, including overflow checks and
> rounding.

Neat. I was poking around waiting on a freeware extended-precision
numerical package, but hadn't found anything with a BSD-style license.

> Another tricky part I expect when telling the parser that a
> literal NUMERIC must not be enclosed into single quotes.

This is probably the worst part, since you would hate to take the hit
representing everything as extended precision even if the actual range
is int4/float8. Perhaps we can read as those, but if we get a failure
then escalate to your extended precision type(s). The automatic type
conversion stuff should convert later if necessary, so it might be
transparent and relatively fast.

> The only ugly thing is, that I needed to put the precision
> AND the scale together into atttypmod (I limited both to 99
> for now and put them as prec<<8 | scale into). So pg_dump
> will need attention later.

As Bruce points out, that was anticipated (but I agree it's ugly). Shift
over 16 bits if you want...

Congrats!

- Tom

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas G. Lockhart 1998-12-19 03:04:37 Re: [HACKERS] 6.4.1 fails to compile
Previous Message Thomas G. Lockhart 1998-12-19 02:52:07 Re: [HACKERS] Help with Documentation?