Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] sbufdesc' padding...

From: Vadim Mikheev <vadim(at)krs(dot)ru>
To: "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: PostgreSQL Developers List <hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] sbufdesc' padding...
Date: 1998-12-01 02:50:44
Message-ID: 36635984.84E60BEF@krs.ru (view raw or flat)
Thread:
Lists: pgsql-hackers
"Thomas G. Lockhart" wrote:
> 
> > * ... this hack cut 10% off of the time to create the Wisconsin
> > * database! It eats up more shared memory, of course, but we're
> > * (allegedly) going to make some of these types bigger soon
> > * anyway... -pma 1/2/93
> > This is not true now:
> > #define BufferDescriptorGetBuffer(bdesc) ((bdesc)->buf_id + 1)
> > Comments ?...
> 
> Does that mean that we have re-introduced the slower allocation
> technique sometime since 1993? 10% speed improvement for some operations
> seems interesting...

Why slower allocation? BufferDescriptorGetBuffer used sizeof sbufdesc
to get buffer number in 1993. Jolly/Andrew put buffer number
(buf_id) into sbufdesc itself and so made sbufdesc padding
useless.

Vadim

In response to

Responses

pgsql-hackers by date

Next:From: Vadim MikheevDate: 1998-12-01 02:51:58
Subject: Re: [HACKERS] COMMIT
Previous:From: Kurt SeelDate: 1998-11-30 21:37:08
Subject: 6.4 core dumping on freebsd 2.2.7

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group