Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug

From: andrew(at)dunslane(dot)net
To: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org, "William ZHANG" <uniware(at)zedware(dot)org>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug
Date: 2006-07-27 00:48:11
Message-ID: 3653.24.211.165.134.1153961291.squirrel@www.dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> Bruce Momjian wrote:
>>>> Why is this better than:
>>>>
>>>>   #if _MSC_VER == 1400
>>>>
>>>>
>>>> Surely this will not be true if _MSC_VER is undefined?
>>> I experienced injustice and the reason of in OSX for it.
>>
>> What was the problem with OSX?  Did it throw a warning of you did an
>> equality test on an undefined symbol?
>
> The following if evaluated to true on osx, although I'm pretty sure that
> _MSC_VER isn't defined on osx ;-)
> #if (_MSC_VER < 1300)
> ...
> #endif
>
> replacing it with
> #ifdef WIN32
> #if (_MSC_VER < 1300)
> ...
> #endif
> #endif
>
> fixed the problem.
>


No doubt, but that's quite a different test.

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Hiroshi SaitoDate: 2006-07-27 00:56:01
Subject: Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug
Previous:From: Florian G. PflugDate: 2006-07-27 00:41:55
Subject: Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug

pgsql-patches by date

Next:From: Hiroshi SaitoDate: 2006-07-27 00:56:01
Subject: Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug
Previous:From: Florian G. PflugDate: 2006-07-27 00:41:55
Subject: Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group