Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] snprintf causes regression

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql(at)mohawksoft(dot)com, Nicolai Tufar <ntufar(at)gmail(dot)com>,Magnus Hagander <mha(at)sollentuna(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Date: 2005-03-11 17:23:36
Message-ID: 3649.1110561816@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> I'm not sure that macros can have variable number of arguments on all
>> supported platforms. I've been burnt by this before.

> The actual patch is:
	
> 	+ #ifdef __GNUC__
> 	+ #define vsnprintf(...)        pg_vsnprintf(__VA_ARGS__)
> 	+ #define snprintf(...) pg_snprintf(__VA_ARGS__)
> 	+ #define printf(...)           pg_printf(__VA_ARGS__)
> 	+ #else
> 	+ #define vsnprintf             pg_vsnprintf
> 	+ #define snprintf              pg_snprintf
> 	+ #define printf                pg_printf
> 	+ #endif

Uh, why bother with the different approach for gcc?

Also, what happened to fprintf?  We're going to need that too for
localization of the client programs.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-03-11 17:37:24
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Previous:From: Chris MairDate: 2005-03-11 17:19:18
Subject: Re: TODO item: support triggers on columns

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-03-11 17:37:24
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Previous:From: Bruce MomjianDate: 2005-03-11 17:14:26
Subject: Re: [pgsql-hackers-win32] snprintf causes regression

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2005-03-11 17:37:24
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Previous:From: Bruce MomjianDate: 2005-03-11 17:14:26
Subject: Re: [pgsql-hackers-win32] snprintf causes regression

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group