Skip site navigation (1) Skip section navigation (2)

Re: BUG #1467: fe_connect doesn't handle EINTR right

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <agentm(at)themactionfaction(dot)com>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: BUG #1467: fe_connect doesn't handle EINTR right
Date: 2005-06-26 23:38:03
Message-ID: 3616.24.211.165.134.1119829083.squirrel@www.dunslane.net (view raw or flat)
Thread:
Lists: pgsql-patches
AgentM said:
> Attached is a patch which corrects the behavior. I verified that the
> patch does not interfere with normal operation (using psql) but
> unfortunately the code path is virtually impossible to test without a
> really slow connection to a postgresql server [which I thankfully
> don't have]. To test the patch, you would need to send an interrupt
> at the exact time that the kernel is connect()ing in blocking mode-
> good luck.
>
> Also, I recommend removing a (sarcastic?) comment left by a previous
> developer- I wrote a note about in my patch.
>
> The patch is against 8.0.3 [because HEAD requires access to a
> specific version of bison] but I imagine that the code hasn't changed
> in fe-connect.c since then.
>
> Patch against src/interfaces/libpq/fe-connect.c (v 8.0.3)

It's not even legal C89 C - please don't use // style comments.

cheers

andrew



In response to

pgsql-patches by date

Next:From: Simon RiggsDate: 2005-06-27 00:41:39
Subject: Constraint Exclusion (Partitioning) - Initial Review requested
Previous:From: Tom LaneDate: 2005-06-26 22:51:41
Subject: Re: BUG #1467: fe_connect doesn't handle EINTR right

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group