Skip site navigation (1) Skip section navigation (2)

Re: pg_upgrade test script creates port conflicts in parallel testing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_upgrade test script creates port conflicts in parallel testing
Date: 2013-01-03 22:57:01
Message-ID: 3613.1357253821@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 01/03/2013 12:58 PM, Tom Lane wrote:
>> Does anyone have an objection to fixing the pg_upgrade test script
>> to suppress the TCP socket?

> Should be OK. We can't do that on Windows, though, so please make it 
> conditional so we don't break Mingw buildfarm members. The test script 
> already contains a few Windows variants.

I'm planning to do it like this:

 testhost=`uname -s`
 
+case $testhost in
+	MINGW*)	LISTEN_ADDRESSES="localhost" ;;
+	*)		LISTEN_ADDRESSES="" ;;
+esac
+
+POSTMASTER_OPTS="-F -c listen_addresses=$LISTEN_ADDRESSES"
+
 temp_root=$PWD/tmp_check

which matches the existing Windows-specific switches.

			regards, tom lane


In response to

pgsql-hackers by date

Next:From: Dan LangilleDate: 2013-01-04 02:01:01
Subject: PGCon 2013 - CFP & unconference day
Previous:From: Joshua D. DrakeDate: 2013-01-03 22:45:11
Subject: Re: Re: Proposal: Store "timestamptz" of database creation on "pg_database"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group