Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date: 2010-12-11 16:38:26
Message-ID: 3510.1292085506@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Sat, Dec 11, 2010 at 17:23, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think the reason it's not failing is that it includes <fcntl.h>.

> S_IRWXU is defined in port/win32.h...

No, it isn't. There's an apparently-useless definition of _S_IRWXU
there, but no S_IRWXU.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2010-12-11 16:44:53 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Previous Message Magnus Hagander 2010-12-11 16:33:04 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-12-11 16:44:53 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Previous Message Magnus Hagander 2010-12-11 16:33:04 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags