Re: [HACKERS] SunOS patches

The Hermit Hacker wrote:

> On Mon, 2 Mar 1998 t-ishii(at)sra(dot)co(dot)jp wrote:
>
> >
> > included are patches for Feb 26 snapshot. I hope these are the last
> > patches for SunOS port:-)
>
> Ack!
>
> > P.S. I didn't see my patches to tempalte/.similar in Mar 1
> > snapshot. Should I repost the patches?
> > ---
> > Tatsuo Ishii
> > t-ishii(at)sra(dot)co(dot)jp
> > ----------------------------------------------------------------------
> > *** backend/libpq/pqcomm.c.orig Fri Feb 27 14:07:52 1998
> > --- backend/libpq/pqcomm.c Fri Feb 27 14:08:50 1998
> > ***************
> > *** 564,571 ****
> > * Shutdown routine for backend connection
> > * If a Unix socket is used for communication, explicitly close it.
> > */
> > ! static void
> > ! do_unlink()
> > {
> > if (sock_path[0])
> > unlink(sock_path);
> > --- 564,571 ----
> > * Shutdown routine for backend connection
> > * If a Unix socket is used for communication, explicitly close it.
> > */
> > ! void
> > ! StreamDoUnlink()
>
> What breaks by renaming this function?? :(

On my linux box:

...
gcc -I../../include -I../../backend -I/usr/include/ncurses
-I/usr/include/readline -O2 -m486 -Wall -Wmissing-prototypes -I.. -c
pqcomm.c -o pqcomm.o
pqcomm.c:569: warning: no previous prototype for `StreamDoUnlink'
...
ipc.c: In function `exitpg':
ipc.c:139: warning: implicit declaration of function `StreamDoUnlink'

Seems to run OK though. Would like to get the warnings out of there for a
release. I didn't pay attention to Tatsuo's earlier patches since they didn't
directly affect my platform; where would these things be declared? Can Tatsuo
come up with a few more patches to fix this up? It would be worth waiting a few
hours on the release to get SunOS in there (the docs claim it is supported :)

- Tom