Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] SunOS patches

From: "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: t-ishii(at)sra(dot)co(dot)jp, PostgreSQL HACKERS <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] SunOS patches
Date: 1998-03-02 03:23:51
Message-ID: 34FA2646.FAA5D571@alumni.caltech.edu (view raw or flat)
Thread:
Lists: pgsql-hackers
The Hermit Hacker wrote:

> On Mon, 2 Mar 1998 t-ishii(at)sra(dot)co(dot)jp wrote:
>
> >
> > included are patches for Feb 26 snapshot. I hope these are the last
> > patches for SunOS port:-)
>
>         Ack!
>
> > P.S. I didn't see my patches to tempalte/.similar in Mar 1
> > snapshot. Should I repost the patches?
> > ---
> > Tatsuo Ishii
> > t-ishii(at)sra(dot)co(dot)jp
> > ----------------------------------------------------------------------
> > *** backend/libpq/pqcomm.c.orig       Fri Feb 27 14:07:52 1998
> > --- backend/libpq/pqcomm.c    Fri Feb 27 14:08:50 1998
> > ***************
> > *** 564,571 ****
> >    * Shutdown routine for backend connection
> >    * If a Unix socket is used for communication, explicitly close it.
> >    */
> > ! static void
> > ! do_unlink()
> >   {
> >       if (sock_path[0])
> >               unlink(sock_path);
> > --- 564,571 ----
> >    * Shutdown routine for backend connection
> >    * If a Unix socket is used for communication, explicitly close it.
> >    */
> > ! void
> > ! StreamDoUnlink()
>
>         What breaks by renaming this function?? :(

On my linux box:

...
gcc -I../../include -I../../backend -I/usr/include/ncurses
-I/usr/include/readline -O2   -m486 -Wall -Wmissing-prototypes -I..    -c
pqcomm.c -o pqcomm.o
pqcomm.c:569: warning: no previous prototype for `StreamDoUnlink'
...
ipc.c: In function `exitpg':
ipc.c:139: warning: implicit declaration of function `StreamDoUnlink'

Seems to run OK though. Would like to get the warnings out of there for a
release. I didn't pay attention to Tatsuo's earlier patches since they didn't
directly affect my platform; where would these things be declared? Can Tatsuo
come up with a few more patches to fix this up? It would be worth waiting a few
hours on the release to get SunOS in there (the docs claim it is supported :)

                                                  - Tom


In response to

Responses

pgsql-hackers by date

Next:From: Vadim B. MikheevDate: 1998-03-02 03:31:03
Subject: Re: [HACKERS] sequences
Previous:From: t-ishiiDate: 1998-03-02 03:21:26
Subject: Re: [HACKERS] SunOS patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group