Re: pgsql: Add regression tests for CSV and \., and add automatic quoting of

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <momjian(at)postgresql(dot)org>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add regression tests for CSV and \., and add automatic quoting of
Date: 2005-12-28 12:35:59
Message-ID: 3440.24.211.165.134.1135773359.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian said:
> Log Message:
> -----------
> Add regression tests for CSV and \., and add automatic quoting of a
> single column dump that has a \. value, so the load works properly. I
> also added documentation describing this issue.
>

This seems unnecessarily elaborate, in code that is already byzantine. I
think we can safely quote *any* field that has \. regardless of whether or
not it is a singleton. There's no need to make a single column a special
case - if it's valid for a singleton it's valid for any, and vice versa.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2005-12-28 13:39:17 Re: pgsql: Add regression tests for CSV and \., and add automatic quoting of
Previous Message Christopher Kings-Lynne 2005-12-28 06:01:35 Re: [COMMITTERS] pgsql: Minor doc tweak: "NOT NULL" is redundant