Re: regression tests for ALTER TABLE ... DEFAULT

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: regression tests for ALTER TABLE ... DEFAULT
Date: 2002-04-24 05:02:49
Message-ID: 3416.1019624569@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> Don't you ever run the tests before checking stuff in?

> ... Nope. I do it once a batch is checked in. I assume submitters have
> already done it. Too much work.

Whether or not you assume that the submitter ran regress tests, it's
unsafe to assume that a several-days-old patch is still good against
current CVS tip. Especially not when you get merge failures, as you
certainly must have in this case.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-04-24 05:06:42 Re: regression tests for ALTER TABLE ... DEFAULT
Previous Message Tom Lane 2002-04-24 04:56:31 Re: unknownin/out patch (was [HACKERS] PQescapeBytea is not