Skip site navigation (1) Skip section navigation (2)

Re: NetBSD/MIPS supports dlopen

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Rémi Zara <remi_zara(at)mac(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: NetBSD/MIPS supports dlopen
Date: 2008-03-05 20:33:57
Message-ID: 3345.1204749237@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Rmi Zara wrote:
>> Recent version of NetBSD/MIPS support dlopen. This patch makes the  
>> netbsd dynloader tests availability of dlopen on HAVE_DLOPEN rather than 
>> on __mips__

> Applied, thanks.

Weird, I haven't seen the commit message come through here.

Anyway: (1) this should probably be back-patched; (2) please clean up
the ugly double negative here:

! #if !defined(HAVE_DLOPEN)
  #else 
        dlclose(handle);
  #endif

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bryce NesbittDate: 2008-03-05 21:06:12
Subject: Proposed patch - psql wraps at window width
Previous:From: Alvaro HerreraDate: 2008-03-05 19:43:28
Subject: Re: NetBSD/MIPS supports dlopen

pgsql-patches by date

Next:From: Edwin GroothuisDate: 2008-03-05 20:49:22
Subject: Re: [BUGS] BUG #3975: tsearch2 index should not bomb out of 1Mb limit
Previous:From: Alvaro HerreraDate: 2008-03-05 19:43:28
Subject: Re: NetBSD/MIPS supports dlopen

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group