Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Pedro J(dot) Lobo" <pjlobo(at)euitt(dot)upm(dot)es>
Cc: PostgreSQL bugs mailing list <pgsql-bugs(at)postgreSQL(dot)org>, PostgreSQL ports mailing list <pgsql-ports(at)postgreSQL(dot)org>
Subject: Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc
Date: 1999-10-08 15:16:57
Message-ID: 3295.939395817@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-ports
"Pedro J. Lobo" <pjlobo(at)euitt(dot)upm(dot)es> writes:
> Someone has changed the "#if defined(__alpha)" tests that existed in
> include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
> is that DEC (Compaq?) C only defines __alpha, (gcc defines both __alpha
> and __alpha__) so it doesn't work anymore.

I thought that was bogus when it was done.  Should be
	#if defined(__alpha) || defined(__alpha__)
to cover both compilers.

> In fact, there are two places where the test is used, one inside a "#if
> defined(__GNUC__)" and the other one inside the corresponding "#else". It
> seems that the easiest sollution is to change the check inside the "#else"
> back to "#if defined(__alpha)".

... which would break whichever compiler is being used by the person who
submitted the patch.  I don't think it was changed on a whim.

			regards, tom lane

Responses

pgsql-ports by date

Next:From: Bruce MomjianDate: 1999-10-08 16:18:24
Subject: Re: [PORTS] postgresql-6.5.2/src/interfaces/odbc/gpps.h
Previous:From: Pedro J. LoboDate: 1999-10-08 14:23:39
Subject: 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

pgsql-bugs by date

Next:From: Bruce MomjianDate: 1999-10-08 16:13:38
Subject: Re: [BUGS] 6.5.2 BUG: Rolling back after dropping a table causes dangling relationships.
Previous:From: Pedro J. LoboDate: 1999-10-08 14:23:39
Subject: 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group