Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

From: Larry Rosenman <ler(at)lerctr(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use
Date: 2004-03-19 15:18:02
Message-ID: 32070000.1079709482@lerlaptop-red.iadfw.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

--On Friday, March 19, 2004 10:15:56 -0500 Bruce Momjian 
<pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:

>> [moved to -patches because of the patch]
>>
>>
>> --On Friday, March 19, 2004 08:01:53 -0500 Bruce Momjian
>> <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
>>
>> > Larry Rosenman wrote:
>> >> > I thought that once you include libpthread in libpq, that you don't
>> >> > have to mention it again then you use libpq.  Is your platform
>> >> > different somehow in this regard?
>> >> >
>> >> > I seem to remember this problem with libcrypt and libpq.  Is this
>> >> > the same problem?
>> >> >
>> >> > I see that initdb is just the first of many /bin programs to be
>> >> > compiled, so if we have to add the thread lib, we will have to do it
>> >> > for all the bin programs.  Yikes.  Why wasn't this a problem for
>> >> > 7.4?
>> >> 7.4 had initdb as a Shell Script.
>> >> the 7.4.x libpq didn't have any pthread_* references in it, that I see
>> >> on my box.
>> >
>> > Ah, yes.  We added the thread-local storage to handle SIGPIPE.  The
>> > problem is that initdb isn't the only place.  If you comment out initdb
>> > from the Makefile in src/bin, does the next make fail too?  I bet it
>> > does.
>>
>> Apparently, because of the way the wrappers work, having -lpthread on
>> libpq.so does NOT add it to the NEEDED list.
>>
>> I made the following patch, and all compiles now:
>
> Yes, I was afraid of that.  Is there any way to make it work?  If not,
> evey libpq program you create will need -lpthread added.
I think we need to mention if you --enable-thread-safety you MUST use 
-lpthread on UnixWare, at least.  I don't know about other platforms.

I'll ask the compiler guys, but I suspect we're going to have to do it this 
way.

LER

>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
>   +  If your life is a hard drive,     |  13 Roberts Road
>   +  Christ can be your backup.        |  Newtown Square, Pennsylvania
> 19073



-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2004-03-19 15:18:26
Subject: Re: COPY formatting
Previous:From: Bruce MomjianDate: 2004-03-19 15:15:56
Subject: Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use threads

pgsql-patches by date

Next:From: Larry RosenmanDate: 2004-03-19 15:47:57
Subject: Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use
Previous:From: Bruce MomjianDate: 2004-03-19 15:15:56
Subject: Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use threads

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group