| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Thomas Hallgren <thhal(at)mailblocks(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Patch that deals with that AtCommit_Portals encounters |
| Date: | 2005-03-16 07:21:32 |
| Message-ID: | 3197.1110957692@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> Thomas Hallgren wrote:
>> This patch will ensure that the hash table iteration performed by
>> AtCommit_Portals is restarted when a portal is deleted.
> I'll apply this to HEAD within 24 hours, barring any objections.
I don't believe that this actually fixes anything.
In particular, if portal A actually tries to reference portal B during
A's deletion, there is only a 50% chance that this prevents problems.
And since the hash table is traversed in hashcode order, you can't
really imagine that you know which one will be deleted first.
I think a correct fix would involve suppressing that reference in the
first place, rather than making ad-hoc alterations in the traversal
behavior.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Hallgren | 2005-03-16 07:43:01 | Re: Patch that deals with that AtCommit_Portals encounters |
| Previous Message | Bruce Momjian | 2005-03-16 06:05:58 | Re: [COMMITTERS] pgsql: Handle carriage returns and line feeds in COPY |