Skip site navigation (1) Skip section navigation (2)

Re: [PORTS] Re: patch for minor Win32 makefile bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
Cc: Fred Yankowski <fred(at)ontosys(dot)com>, pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Date: 2001-04-04 04:44:08
Message-ID: 309.986359448@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patchespgsql-ports
Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> On Tue, Apr 03, 2001 at 06:03:45PM -0400, Tom Lane wrote:
>> Hmm.  It seems a little bit weird (no, a lot weird) to be referencing
>> -lpostgres for the client-side interface library builds.  I can see that
>> the PL-language DLLs might need to reference -lpostgres during their
>> links, but I've got severe doubts that this is a good idea anyplace
>> else.

> You are correct.  I just verified by using MS's dumpbin that none
> of the above DLLs except for plpgsql.dll actually import any symbols
> from libpostgres.a.  Hence, linking the client-side interface libraries
> with libpostgres.a is superfluous.
> However, you missed a few regression test related DLLs.  See below for
> details.

Good point; those DLLs link into the backend.

Maybe Makefile.win should define FE_DLLLIBS (for frontend libraries)
and BE_DLLLIBS (for backend libraries).  That would require any
particular Makefile that's building a DLL to select one or the other
to define DLLLIBS as, before it could include Makefile.shlib.  Is that
approach good for clarity, or too much of a pain-in-the-neck?

			regards, tom lane

In response to

Responses

pgsql-ports by date

Next:From: lsmithDate: 2001-04-04 12:07:22
Subject: 'ATAL1:badabstime error on Windows 2000, also interested in binary to dwld
Previous:From: Jason TishlerDate: 2001-04-04 02:40:32
Subject: Re: Re: [PATCHES] patch for minor Win32 makefile bug

pgsql-patches by date

Next:From: Ronald KuczekDate: 2001-04-04 13:24:37
Subject: RE: FAQ_MSWIN patch
Previous:From: Jason TishlerDate: 2001-04-04 02:40:32
Subject: Re: Re: [PATCHES] patch for minor Win32 makefile bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group