Skip site navigation (1) Skip section navigation (2)

Re: Extending grant insert on tables to sequences

From: "Jaime Casanova" <jcasanov(at)systemguards(dot)com(dot)ec>
To: "Abhijit Menon-Sen" <ams(at)oryx(dot)com>
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Jaime Casanova" <systemguards(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Extending grant insert on tables to sequences
Date: 2008-07-12 19:32:03
Message-ID: 3073cc9b0807121232m6b8e6ae0ycaa78d6b8595d39d@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Sat, Jul 12, 2008 at 6:30 AM, Abhijit Menon-Sen <ams(at)oryx(dot)com> wrote:
>
>>      <para>
>> !     Granting permission on a table automatically extend
>> !     permissions to any sequences owned by the table, including
>> !     sequences tied to <type>SERIAL</> columns.
>>      </para>
>
> Should be "Granting permissions on a table automatically extends those
> permissions to...".
>

what about "extends them to..."

>> +     if ((istmt.objtype == ACL_OBJECT_RELATION) && (istmt.all_privs ||
>> +             (istmt.privileges & (ACL_INSERT | ACL_UPDATE | ACL_SELECT))))
>> +     {
>
> The parentheses around the first comparison can go away, and also the
> ones around the ACL_* here:
>

ok

-- 
regards,
Jaime Casanova
Soporte y capacitaciĆ³n de PostgreSQL
Guayaquil - Ecuador
Cel. (593) 87171157

Attachment: grant_seq-v3.patch
Description: text/x-diff (4.0 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Abhijit Menon-SenDate: 2008-07-12 19:52:37
Subject: Re: Extending grant insert on tables to sequences
Previous:From: Tom LaneDate: 2008-07-12 19:17:59
Subject: Re: PATCH: CITEXT 2.0 v3

pgsql-patches by date

Next:From: Abhijit Menon-SenDate: 2008-07-12 19:52:37
Subject: Re: Extending grant insert on tables to sequences
Previous:From: Tom LaneDate: 2008-07-12 18:27:57
Subject: Re: Relation forks & FSM rewrite patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group