On Sat, Jul 12, 2008 at 6:30 AM, Abhijit Menon-Sen <ams(at)oryx(dot)com> wrote:
>
>>      <para>
>> !     Granting permission on a table automatically extend
>> !     permissions to any sequences owned by the table, including
>> !     sequences tied to <type>SERIAL</> columns.
>>      </para>
>
> Should be "Granting permissions on a table automatically extends those
> permissions to...".
>

what about "extends them to..."

>> +     if ((istmt.objtype == ACL_OBJECT_RELATION) && (istmt.all_privs ||
>> +             (istmt.privileges & (ACL_INSERT | ACL_UPDATE | ACL_SELECT))))
>> +     {
>
> The parentheses around the first comparison can go away, and also the
> ones around the ACL_* here:
>

ok

-- 
regards,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Guayaquil - Ecuador
Cel. (593) 87171157

In response to

• Re: Extending grant insert on tables to sequences at 2008-07-12 11:30:41 from Abhijit Menon-Sen

Responses

• Re: Extending grant insert on tables to sequences at 2008-07-12 19:52:37 from Abhijit Menon-Sen
• Re: Extending grant insert on tables to sequences at 2008-07-12 20:06:51 from Tom Lane

pgsql-hackers by date

Next:	From: Abhijit Menon-Sen	Date: 2008-07-12 19:52:37
	Subject: Re: Extending grant insert on tables to sequences
Previous:	From: Tom Lane	Date: 2008-07-12 19:17:59
	Subject: Re: PATCH: CITEXT 2.0 v3

pgsql-patches by date

Next:	From: Abhijit Menon-Sen	Date: 2008-07-12 19:52:37
	Subject: Re: Extending grant insert on tables to sequences
Previous:	From: Tom Lane	Date: 2008-07-12 18:27:57
	Subject: Re: Relation forks & FSM rewrite patches