Re: Extending grant insert on tables to sequences

From: "Jaime Casanova" <jcasanov(at)systemguards(dot)com(dot)ec>
To: "Abhijit Menon-Sen" <ams(at)oryx(dot)com>
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Jaime Casanova" <systemguards(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Extending grant insert on tables to sequences
Date: 2008-07-11 16:57:37
Message-ID: 3073cc9b0807110957w71869487p17fb58cb98abc520@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Wed, Jul 9, 2008 at 10:11 PM, Abhijit Menon-Sen <ams(at)oryx(dot)com> wrote:
> At 2008-07-09 15:11:25 -0400, alvherre(at)commandprompt(dot)com wrote:
>>
>> No, actually I meant having a lone "list = lappend(list, newseq);" in
>> the loop, so that ExecGrantStmt_oids is called only once.
>
> Yes, I understand what you meant. I just phrased my agreement poorly.
> Here's a more precise phrasing. ;-)
>
> (I agree with Robert Treat that there seems to be no point granting
> SELECT on the sequence. I don't *particularly* care about it, but I
> tend towards wanting to drop that bit. This patch reflects that.)
>

Hi,
sorry for the delay i was busy...

attached is a new version of the patch, it implements Alvaro's
suggestion and fix a bug i found (it wasn't managing GRANT ALL) :(

About the SELECT issue, AFAIU Robert doesn't complaint he just asked
what is the use case... if people think it should be removed ok, but
OTOH: why? i don't think that affects anything...

--
regards,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Guayaquil - Ecuador
Cel. (593) 87171157

Attachment Content-Type Size
grant_seq-v2.patch text/x-diff 4.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-07-11 17:06:49 _bt_delitems: change before WAL?
Previous Message claudio lezcano 2008-07-11 16:31:06 building postgres test examples in win32

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-07-11 21:08:55 Re: [PATCHES] GIN improvements
Previous Message Abhijit Menon-Sen 2008-07-11 10:02:16 Re: posix advises ...