Skip site navigation (1) Skip section navigation (2)

Re: Win32 signals code, take two

From: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "pgsql-hackers-win32" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: Win32 signals code, take two
Date: 2004-01-19 14:24:15
Message-ID: 303E00EBDD07B943924382E153890E5434AA65@cuthbert.rcsinc.local (view raw or flat)
Thread:
Lists: pgsql-hackers-win32
Magnus Hagander wrote:
> Here's an updated version of the proposed win32 signals code, with the
> following main changes:

One small possible revision to consider:  As I read the code, all
manipulation to pg_signal_queue is inside a CriticalSection, and it is
only set (> 0) when there are pending signals.  

ISTM that pg_queue_signal can abort without calling QueueUserAPC
pg_signal_queue is already set.  This will keep the dispatch function
from getting called extra times.  Paranoia statement 

pg_signal_queue = 0; 

could possibly be added at the end of the dispatch.

Everything else looks good to me.  Looking at the code, pg_signal_queue
is better and simpler than the event based method I was suggesting, IMO.

Merlin

pgsql-hackers-win32 by date

Next:From: Magnus HaganderDate: 2004-01-19 14:36:18
Subject: Re: Win32 signals code, take two
Previous:From: Claudio NatoliDate: 2004-01-19 13:03:09
Subject: Re: Win32 signals code, take two

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group