Re: Updated COPY CSV patch

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Updated COPY CSV patch
Date: 2004-04-14 09:37:23
Message-ID: 3039.24.211.141.25.1081935443.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Karel Zak said:
> On Tue, Apr 13, 2004 at 10:43:35AM -0400, Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> > Thinking about this some more .... maybe the right rule would be
>> > "quote all non-numeric non-null values".
>>
>> And how would you define "numeric"?
>
> And don't forget that number format depend on locale. Now we ignore
> LC_NUMERIC, but maybe at some time in future we will support it. I
> think the best solution is quote all values including numerics too.
>
> 123,456 (in Czech this is one number with decimal "point" ;-)
>

I am assuming that such users would use a delimiter other than a comma.
Any string that contains the delimiter *must* be quoted, regardless of
type. That's just the way CSVs work - it's not an artifact of ours.

cheers

andrew

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2004-04-14 10:14:22 Re: Updated COPY CSV patch
Previous Message Andrew Dunstan 2004-04-14 09:27:57 Re: Updated COPY CSV patch