Re: [PATCHES] pg_dump lock timeout

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: daveg <daveg(at)sonic(dot)net>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, pgsql-patches(at)postgresql(dot)org, hari(at)efrontier(dot)com, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] pg_dump lock timeout
Date: 2008-07-03 15:33:16
Message-ID: 3001.1215099196@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

daveg <daveg(at)sonic(dot)net> writes:
> On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote:
>> - The statement_timeout is set back with "statement_timeout = default"
>> Maybe it would be better to do "= 0" here? Although such decision
>> would go outside the scope of the patch, I see no sense having
>> any other statement_timeout for actual dumping.

> I'd prefer to leave whatever policy is otherwise in place alone.

The policy in place in CVS HEAD is that pg_dump explicitly sets
statement_timeout to 0. Setting it to default would break that,
and will certainly not be accepted.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2008-07-03 16:01:17 Re: PATCH: CITEXT 2.0
Previous Message chris 2008-07-03 15:30:28 Re: A Windows x64 port of PostgreSQL

Browse pgsql-patches by date

  From Date Subject
Next Message Garick Hamlin 2008-07-03 17:36:28 Solaris ident authentication using unix domain sockets
Previous Message Heikki Linnakangas 2008-07-03 14:04:51 Re: page macros cleanup