Skip site navigation (1) Skip section navigation (2)

Re: Open 7.1 items

From: Philip Warner <pjw(at)rhyme(dot)com(dot)au>
To: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgman(at)candle(dot)pha(dot)pa(dot)us
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Open 7.1 items
Date: 2001-01-28 01:53:01
Message-ID: 3.0.5.32.20010128125301.02f687e0@mail.rhyme.com.au (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-jdbc
At 07:24 26/01/01 +0900, Tatsuo Ishii wrote:
>> Fix for pg_dump of bad system tables
>
>Ok. I have made patches for fixing some of pg_dump problems(see
>attached patches). 
...
>Also I'm not quite sure "#arg" (stringification) is
>portable enough in all platforms.)  

The patch looks fine to me, but I have no idea how portable #arg is - does
anybody else have some facts on the matter: 

+#define AGG_NOTICE(arg) {\
+               fprintf(stderr, "Notice: aggregate \"%s\"(oid %s) is not
dumped.\n",agginfo[i].aggname, a
+       fprintf(stderr, "Reason: " #arg);\
+       fprintf (stderr, " (oid %s) not found.\n",agginfo[i].arg);\
+       }
+

It's easy enough to change the macros to take 2 params, and that would be
my inclination if it's not a solid part of the C standard (for any
non-trivial definintion of 'solid').


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 0500 83 82 82         |                 ___________ |
Http://www.rhyme.com.au          |                /           \|
                                 |    --________--
PGP key available upon request,  |  /
and from pgp5.ai.mit.edu:11371   |/

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2001-01-28 02:14:51
Subject: Re: Open 7.1 items
Previous:From: Hannu KrosingDate: 2001-01-28 01:34:06
Subject: Re: Re: [GENERAL] MySQL -> Postgres dump converter

pgsql-jdbc by date

Next:From: Tom LaneDate: 2001-01-28 02:14:51
Subject: Re: Open 7.1 items
Previous:From: Peter MountDate: 2001-01-27 17:01:24
Subject: Re: [BUGS] no way in LargeObject API to detect short read?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group