Revised patches to add table function support to PL/Tcl (TODO item)

From: Karl Lehenbauer <karllehenbauer(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Revised patches to add table function support to PL/Tcl (TODO item)
Date: 2010-12-28 22:56:23
Message-ID: 2A558223-09B0-402E-9304-E1EF77152D02@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In response to Alvaro Herrera's message from today I've split the PL/Tcl table function patch into three separate, easier-to-digest patches. (Thanks for the quick response, Alvaro.)

The first patch, pltcl-karl-try2-1-of-3-pgindent.patch, does nothing but conform HEAD's pltcl.c with pgindent. Applying this patch should have exactly the same effect as running
src/tools/pgindent/pgindent src/tools/pgindent/typedefs.list src/pl/tcl/pltcl.c

The second patch, pltcl-karl-try2-2-of-3-objects.patch, should be applied after the first, and updates PL/Tcl to use the Tcl "Tcl object" C API, the preferred way of interacting with Tcl from C since Tcl 8.0 was released in 1997.

The third patch, pltcl-karl-try2-3-of-3-setof.patch, builds on the above to add both the "return_next" command for returning multiple rows in a SETOF-returning function and to add using "return" with a list of key-value pairs for functions returning a non-SETOF record.

Attachment Content-Type Size
pltcl-karl-try2-1-of-3-pgindent.patch application/octet-stream 16.7 KB
pltcl-karl-try2-2-of-3-objects.patch application/octet-stream 34.2 KB
pltcl-karl-try2-3-of-3-setof.patch application/octet-stream 39.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Wilson 2010-12-28 23:00:46 Re: pg_dump --split patch
Previous Message Gurjeet Singh 2010-12-28 22:55:48 Re: pg_dump --split patch