From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us>, Markus <markus(dot)herven(at)outpost24(dot)com>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #5478: ILIKE operator returns wrong result |
Date: | 2010-05-28 16:50:17 |
Message-ID: | 29807.1275065417@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
BTW, while I'm looking at this, I notice that there was an oversight in
the change that made us throw an error for \ at the end of the LIKE
pattern. We throw error in the first code chunk that deals with \
but we don't do so here:
if (plen < 2)
return LIKE_FALSE;
firstpat = CHAR(p[1]);
In some cases the problem is masked because we'll eventually apply the
normal \ processing, but I think there are other cases where we'll reach
a LIKE_ABORT condition and return false without ever throwing the error.
Seems like this should be fixed. But should we back-patch that fix into
8.4? We didn't backpatch the original change for fear of breaking
existing apps, and the same argument could probably be made this time.
Should I change it in 8.4, or only 9.0?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2010-05-28 17:20:29 | Re: BUG #5477: CREATE DOMAIN NOT NULL constraints not always enforced for INSERT with subquery |
Previous Message | Tom Lane | 2010-05-28 16:11:40 | Re: BUG #5478: ILIKE operator returns wrong result |