Skip site navigation (1) Skip section navigation (2)

Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in
Date: 2010-09-28 21:56:57
Message-ID: 29750.1285711017@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> In pg_upgrade, properly handle oids > 2^31 by using strtoul() internally
> rather than atol().

It would be a lot better if this code adhered to the project-standard
coding convention of defining and using an atooid() macro for the
purpose of converting text representations of OIDs to bits.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2010-09-28 22:09:12
Subject: pgsql: Improve messages for too many private files/dirs. Per Alexey Pa
Previous:From: Bruce MomjianDate: 2010-09-28 21:41:07
Subject: pgsql: In pg_upgrade,properly handle oids > 2^31 by using strtoul() in

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group