Re: [COMMITTERS] pgsql/ oc/src/sgml/runtime.sgml rc/backend/uti ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql/ oc/src/sgml/runtime.sgml rc/backend/uti ...
Date: 2001-05-19 14:28:07
Message-ID: 29733.990282487@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> createlang tries to be helpful by trying test -f $the_file first, to guard
> against attempts to load PL/Tcl when no Tcl support was configured. This
> approach has a few other subtle flaws: it requires createlang to be run
> on the server machine and under the same user account as the server.
> Maybe we could devise another way to determine gracefully whether a given
> PL is installed.

Try eliminating the test entirely. CREATE FUNCTION now checks to make
sure that it can find the specified library (and that the named function
exists therein), so as long as createlang aborts on CREATE FUNCTION
failure, I see no need for a separate test.

>> 2. Likewise for CREATE FUNCTION commands in regress tests.

> The shared objects used in the regression test are not located relative to
> the $libdir. Some for the various tutorials, examples.

Duh. Never mind that then ...

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2001-05-20 01:11:49 pgsql/doc TODO
Previous Message Peter Eisentraut - PostgreSQL 2001-05-19 09:28:08 pgsql/src/backend/utils/fmgr fmgr.c

Browse pgsql-hackers by date

  From Date Subject
Next Message mlw 2001-05-19 14:41:54 Re: External search engine, advice
Previous Message mlw 2001-05-19 14:21:27 C++ Headers