Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Apr 4, 2011, at 1:46 AM, Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com> wrote:
>> On Sun, Apr 3, 2011 at 11:23 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> Thanks for the patch, but I think you forgot to worry about overflow:
>> cash_in doesn't test for overflow, either (tested on 8.4.0, 9.0.3, and HEAD):
>> Is this a bug?
> Seems like it. You have to feel sorry for the guy who deposits 9 quintillion dollars and then gets a note from the bank saying his account is overdrawn...
I'm fairly sure that *none* of the money operations bother to check for
overflow; not only input, but arithmetic. That falls somewhere between
bug and missing feature. It's probably worth fixing but seems outside
the scope of the current patch.
In the meantime, I'm not sure whether the newly added functions should
be held to a higher standard than the existing ones. It might be better
to leave it be, and plan to fix them all at once in a consistent style.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2011-04-04 15:01:15|
|Subject: Re: cast from integer to money|
|Previous:||From: Robert Haas||Date: 2011-04-04 14:57:55|
|Subject: Re: [HACKERS] Uppercase SGML entity declarations|