Skip site navigation (1) Skip section navigation (2)

Re: txid strtoull fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marko Kreen" <markokr(at)gmail(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: txid strtoull fix
Date: 2007-10-08 20:27:29
Message-ID: 29587.1191875249@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
"Marko Kreen" <markokr(at)gmail(dot)com> writes:
> I noticed strtoull() causes problems on some buildfarm
> machines.  As a fix I propose small str2num function inside
> txid.c itself.  Main reason is that the txid actually does
> not need fully-featured strtoull (radixes, whitespace skipping).

Seems like a sane solution to me --- applied.

(Note that your overflow test didn't actually work; AFAIK there
really isn't any decent solution other than dividing at each step.)

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Marko KreenDate: 2007-10-08 20:51:28
Subject: Re: txid strtoull fix
Previous:From: Marko KreenDate: 2007-10-08 19:47:14
Subject: txid strtoull fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group