Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] 0x1A in control file on Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [HACKERS] 0x1A in control file on Windows
Date: 2008-09-24 13:18:13
Message-ID: 29574.1222262293@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Andrew Dunstan wrote:
>> Tom Lane wrote:
>>> If you need a positive reason why this might be a bad idea, consider the
>>> idea that someone is examining postgresql.conf with a text editor that
>>> stops reading at control-Z.  He might not be able to see items that the
>>> postmaster is treating as valid.
>> 
>> Yes, exactly right. We certainly can't just open everything in binary
>> mode. Magnus did say that all the current config files are opened in
>> text mode as far as he could see.

> The point being that the config files are opened with AllocateFile(),
> which in turn calls fopen(). It doesn't use open(). The proposal was
> only to make all *open()* calls do it binary. I was under the impression
> that on Unix, that's what open() did, so we should behave the same?

That seems just weird.  I do not think there's any correlation between
whether we use open or fopen and whether the file is text or binary.
Even if it happens to be true right now, depending on it would be
fragile.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2008-09-24 13:27:32
Subject: Re: [HACKERS] 0x1A in control file on Windows
Previous:From: Simon RiggsDate: 2008-09-24 12:48:45
Subject: Re: [PATCHES] Subtransaction commits and Hot Standby

pgsql-bugs by date

Next:From: Andrew DunstanDate: 2008-09-24 13:27:32
Subject: Re: [HACKERS] 0x1A in control file on Windows
Previous:From: Magnus HaganderDate: 2008-09-24 09:02:55
Subject: Re: [HACKERS] 0x1A in control file on Windows

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group