From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: code cleanup for tz |
Date: | 2005-06-20 23:53:58 |
Message-ID: | 29459.1119311638@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> Tom Lane wrote:
>> I think mostly what you are doing here is causing code drift from the
>> upstream "zic" code. I don't think that's a very good idea, since we
>> do need to be able to track and apply bug fixes from them from time
>> to time ...
> Why run pgindent on the timezone code, then? That seems guaranteed to
> cause a lot more merge headaches...
Well, it's certainly hopeless to expect "patch" to fix it :-(. But the
further the code drifts the harder it gets to compare manually.
This isn't an academic concern; I went through it once already, and I
expect we'll want to do it again every release cycle when we sync the
zic database with upstream.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2005-06-21 00:01:20 | Re: code cleanup for tz |
Previous Message | Tom Lane | 2005-06-20 23:49:13 | Re: Optional REFERENCES Feature in CREATE TRIGGER Command |