Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi
Date: 2012-11-14 23:57:13
Message-ID: 29287.1352937433@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

BTW, this patch isn't looking so good on Windows. Buildfarm member
chough says

"C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
(contrib\pg_upgrade target) ->
.\contrib\pg_upgrade\relfilenode.c(202): warning C4003: not enough actual parameters for macro 'open'

"C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
(contrib\pg_upgrade target) ->
.\contrib\pg_upgrade\relfilenode.c(202): error C2059: syntax error : ')'
.\contrib\pg_upgrade\relfilenode.c(207): error C2181: illegal else without matching if
.\contrib\pg_upgrade\relfilenode.c(242): error C2059: syntax error : 'return'
.\contrib\pg_upgrade\relfilenode.c(243): error C2059: syntax error : '}'

1 Warning(s)
4 Error(s)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2012-11-15 00:01:34 pgsql: In pg_upgrade, add third meaningless parameter to open().
Previous Message Bruce Momjian 2012-11-14 23:28:41 Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2012-11-15 00:03:50 Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi
Previous Message Bruce Momjian 2012-11-14 23:55:52 Re: Pg_upgrade speed for many tables