Skip site navigation (1) Skip section navigation (2)

Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi
Date: 2012-11-14 23:57:13
Message-ID: 29287.1352937433@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
BTW, this patch isn't looking so good on Windows.  Buildfarm member
chough says

"C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
(contrib\pg_upgrade target) -> 
  .\contrib\pg_upgrade\relfilenode.c(202): warning C4003: not enough actual parameters for macro 'open'


"C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
(contrib\pg_upgrade target) -> 
  .\contrib\pg_upgrade\relfilenode.c(202): error C2059: syntax error : ')'
  .\contrib\pg_upgrade\relfilenode.c(207): error C2181: illegal else without matching if
  .\contrib\pg_upgrade\relfilenode.c(242): error C2059: syntax error : 'return'
  .\contrib\pg_upgrade\relfilenode.c(243): error C2059: syntax error : '}'

    1 Warning(s)
    4 Error(s)

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2012-11-15 00:03:50
Subject: Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi
Previous:From: Bruce MomjianDate: 2012-11-14 23:55:52
Subject: Re: Pg_upgrade speed for many tables

pgsql-committers by date

Next:From: Bruce MomjianDate: 2012-11-15 00:01:34
Subject: pgsql: In pg_upgrade, add third meaningless parameter to open().
Previous:From: Bruce MomjianDate: 2012-11-14 23:28:41
Subject: Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group